Offline Support

supabase/migrations/20260323000000_fix_enqueue_all_notifications.sql

@@ -1,18 +1,27 @@
--- Migration: Definitive enqueue_all_notifications() dispatcher
+-- Migration: Definitive enqueue_all_notifications() dispatcher + self-hosted fix
 --
 -- WHY THIS EXISTS:
---   20260322_finalize_notification_functions.sql has an underscore at character
---   position 9 of its filename, which sorts AFTER all 20260322NNNNNN_* files
---   (underscore ASCII 95 > digits ASCII 48-57). This means _finalize_ always
---   runs LAST in the 20260322 group, overriding enqueue_all_notifications()
---   with a version that omits:
---     - enqueue_announcement_banner_notifications()  (added in 20260322210000)
---     - enqueue_pass_slip_expired_notifications()    (added in 20260322150000)
+--   1. Sort-order bug: 20260322_finalize_notification_functions.sql has an
+--      underscore at filename position 9, which sorts AFTER all 20260322NNNNNN_*
+--      files (underscore ASCII 95 > digits 48-57). It therefore ran LAST and
+--      overrode enqueue_all_notifications() with a version that omitted:
+--        - enqueue_announcement_banner_notifications()  (added in 20260322210000)
+--        - enqueue_pass_slip_expired_notifications()    (added in 20260322150000)
+--      This migration (20260323000000) sorts after all 20260322* files and
+--      restores the authoritative 10-type definition.
 --
---   This migration (20260323000000) sorts AFTER all 20260322* files and
---   redefines enqueue_all_notifications() as the single authoritative definition
---   that includes all 10 notification types.
+--   2. Self-hosted Docker: process_notification_queue() fires the edge function
+--      via pg_net (HTTP), but on self-hosted the vault secrets and GUC fallbacks
+--      are often not configured, so the function returns early and the edge
+--      function is never triggered. enqueue_all_notifications() therefore never
+--      runs and scheduled_notifications is never populated.
+--      Fix: a dedicated pg_cron job calls enqueue_all_notifications() directly
+--      (pure SQL, no HTTP, no vault required). The edge function is still called
+--      for FCM delivery — only the enqueue step is decoupled.
 
+-- ============================================================================
+-- 1. Authoritative master dispatcher (all 10 types)
+-- ============================================================================
 CREATE OR REPLACE FUNCTION public.enqueue_all_notifications()
 RETURNS void LANGUAGE plpgsql AS $$
 BEGIN
@@ -28,3 +37,40 @@ BEGIN
   PERFORM public.enqueue_announcement_banner_notifications();
 END;
 $$;
+
+-- ============================================================================
+-- 2. Dedicated enqueue cron job (self-hosted compatible)
+-- ============================================================================
+-- This job calls enqueue_all_notifications() directly inside PostgreSQL every
+-- minute. It requires only pg_cron — no pg_net, no vault, no HTTP.
+--
+-- On Supabase cloud:   both this job and the edge-function trigger run, which
+--                      is safe because every enqueue function is idempotent via
+--                      ON CONFLICT DO NOTHING.
+-- On self-hosted Docker: this job ensures scheduled_notifications is populated
+--                      even when the pg_net → edge-function path is broken.
+--                      For FCM delivery you still need the edge function to
+--                      run; use the system crontab as shown below if pg_net
+--                      is not configured:
+--
+--   */1 * * * * curl -sS -X POST \
+--     "http://localhost:8000/functions/v1/process_scheduled_notifications" \
+--     -H "Authorization: Bearer <service-role-key>" \
+--     -H "Content-Type: application/json" -d '{}'
+--
+-- Self-hosted vault / GUC setup (run once, required for pg_net path):
+--   SELECT vault.create_secret('http://localhost:8000', 'supabase_url');
+--   SELECT vault.create_secret('<service-role-key>', 'service_role_key');
+--   -- or via GUC (no vault extension required):
+--   ALTER DATABASE postgres SET "app.settings.supabase_url"    = 'http://localhost:8000';
+--   ALTER DATABASE postgres SET "app.settings.service_role_key" = '<service-role-key>';
+DO $$
+BEGIN
+  PERFORM cron.schedule(
+    'notification_enqueue_every_min',
+    '*/1 * * * *',
+    'SELECT public.enqueue_all_notifications();'
+  );
+EXCEPTION WHEN others THEN
+  RAISE NOTICE 'pg_cron not available (%). Use the system crontab to call the edge function directly instead.', SQLERRM;
+END $$;