QA hardening: security RLS fixes, Flutter 3.47.5 upgrade, UI/validation fixes

Security — enforce write authorization server-side (was UI/RPC-only):
- it_service_requests RLS: block cross-office read/edit + self-approve (QA-015)
- pass_slips RLS: owner can complete but not self-approve (QA-046)
- swap_requests RLS: scope select/update to participants + admin (QA-047)
- storage: tighten it_service_attachments + task_attachments write/delete (QA-027)
- admin_user_management edge function: allow programmers to manage users (QA-016)

Fixes:
- workforce generator "uncovered shifts" false alarms (QA-043/044)
- network-map VLAN + New-location dialog validation, disabled-until-valid (QA-048)
- de-flake time-of-day-dependent dashboard metrics test (QA-045)

Toolchain:
- upgrade to Flutter 3.47.5 / Dart 3.13.4; font_awesome_flutter 11.0.0,
  flutter_quill 11.6.0, pdfrx 2.6.5; clear resulting deprecations (QA-002)

analyze clean; 139 tests pass; web build succeeds. Report + evidence in docs/qa/.

Note: also carries the in-progress Brick model cleanup already present in the
working tree. QA-001 (AI keys public in the build) is deferred by owner decision.

Co-Authored-By: claude-flow <ruv@ruv.net>
This commit is contained in:
2026-09-26 11:52:16 +08:00
parent e49b52949c
commit 3cb980b629
125 changed files with 3420 additions and 2853 deletions
+27 -9
View File
@@ -5,20 +5,20 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:awesome_snackbar_content/awesome_snackbar_content.dart';
import 'package:supabase_flutter/supabase_flutter.dart';
import 'package:tasq/models/attendance_log.dart';
import 'package:tasq/models/notification_item.dart';
import 'package:tasq/models/office.dart';
import 'package:tasq/models/pass_slip.dart';
import 'package:tasq/models/profile.dart';
import 'package:tasq/models/task.dart';
import 'package:tasq/models/attendance_log.model.dart';
import 'package:tasq/models/notification_item.model.dart';
import 'package:tasq/models/office.model.dart';
import 'package:tasq/models/pass_slip.model.dart';
import 'package:tasq/models/profile.model.dart';
import 'package:tasq/models/task.model.dart';
import 'package:tasq/models/task_assignment.dart';
import 'package:tasq/models/ticket.dart';
import 'package:tasq/models/ticket.model.dart';
import 'package:tasq/models/user_office.dart';
import 'package:tasq/models/team.dart';
import 'package:tasq/models/team.model.dart';
import 'package:tasq/utils/app_time.dart';
import 'package:go_router/go_router.dart';
import 'package:tasq/models/team_member.dart';
import 'package:tasq/models/announcement.dart';
import 'package:tasq/models/announcement.model.dart';
import 'package:tasq/providers/announcements_provider.dart';
import 'package:tasq/utils/snackbar.dart' show scaffoldMessengerKey;
import 'package:tasq/providers/attendance_provider.dart';
@@ -554,6 +554,7 @@ void main() {
);
await tester.pumpAndSettle();
await _pickOffice(tester);
await tester.tap(find.text('Create'));
await tester.pumpAndSettle();
@@ -597,6 +598,7 @@ void main() {
);
await tester.pumpAndSettle();
await _pickOffice(tester);
await tester.tap(find.text('Create'));
await tester.pump(); // start saving
expect(find.byType(CircularProgressIndicator), findsOneWidget);
@@ -627,6 +629,7 @@ void main() {
);
await tester.pumpAndSettle();
await _pickOffice(tester);
await tester.tap(find.text('Create'));
await tester.pumpAndSettle();
@@ -678,6 +681,7 @@ void main() {
);
await tester.pumpAndSettle();
await _pickOffice(tester);
await tester.tap(find.text('Create'));
await tester.pump();
expect(find.byType(CircularProgressIndicator), findsOneWidget);
@@ -802,7 +806,21 @@ Future<void> _pumpScreen(
Future<void> _setSurfaceSize(WidgetTester tester, Size size) async {
await tester.binding.setSurfaceSize(size);
// setSurfaceSize alone leaves MediaQuery at the 800x600 default; size the
// view too so breakpoint checks see the same width as the layout.
tester.view.physicalSize = size;
tester.view.devicePixelRatio = 1.0;
addTearDown(() async {
await tester.binding.setSurfaceSize(null);
tester.view.resetPhysicalSize();
tester.view.resetDevicePixelRatio();
});
}
/// Office is required in the ticket/task create dialogs.
Future<void> _pickOffice(WidgetTester tester) async {
await tester.tap(find.text('Select office…'));
await tester.pumpAndSettle();
await tester.tap(find.widgetWithText(ListTile, 'HQ').last);
await tester.pumpAndSettle();
}