chore: remove unused profile lock migration and admin_profile_service

This commit is contained in:
2026-02-18 18:13:10 +08:00
parent e3afd51410
commit 04fd874a48
18 changed files with 1471 additions and 220 deletions
+107
View File
@@ -9,6 +9,8 @@ import 'package:tasq/models/profile.dart';
import 'package:tasq/models/task.dart';
import 'package:tasq/models/ticket.dart';
import 'package:tasq/models/user_office.dart';
import 'package:tasq/models/team.dart';
import 'package:tasq/models/team_member.dart';
import 'package:tasq/providers/notifications_provider.dart';
import 'package:tasq/providers/profile_provider.dart';
@@ -22,6 +24,8 @@ import 'package:tasq/screens/admin/user_management_screen.dart';
import 'package:tasq/screens/tasks/tasks_list_screen.dart';
import 'package:tasq/screens/tickets/tickets_list_screen.dart';
import 'package:tasq/screens/tickets/ticket_detail_screen.dart';
import 'package:tasq/screens/teams/teams_screen.dart';
import 'package:tasq/providers/teams_provider.dart';
// Test double for NotificationsController so widget tests don't initialize
// a real Supabase client.
@@ -175,6 +179,109 @@ void main() {
expect(tester.takeException(), isNull);
});
testWidgets('Teams screen renders without layout exceptions', (
tester,
) async {
await _setSurfaceSize(tester, const Size(1024, 800));
await _pumpScreen(
tester,
const TeamsScreen(),
overrides: [
...baseOverrides(),
teamsProvider.overrideWith((ref) => Stream.value(const <Team>[])),
teamMembersProvider.overrideWith(
(ref) => Stream.value(const <TeamMember>[]),
),
],
);
await tester.pump();
await tester.pump(const Duration(milliseconds: 16));
expect(tester.takeException(), isNull);
});
testWidgets('Add Team dialog requires at least one office', (tester) async {
await _setSurfaceSize(tester, const Size(600, 800));
await _pumpScreen(
tester,
const TeamsScreen(),
overrides: [
...baseOverrides(),
teamsProvider.overrideWith((ref) => Stream.value(const <Team>[])),
teamMembersProvider.overrideWith(
(ref) => Stream.value(const <TeamMember>[]),
),
],
);
// Open Add Team dialog
await tester.tap(find.byType(FloatingActionButton));
await tester.pumpAndSettle();
// Enter name
final nameField = find.byType(TextField).first;
await tester.enterText(nameField, 'Alpha Team');
await tester.pumpAndSettle();
// Select leader (it_staff)
final leaderDropdown = find.widgetWithText(
DropdownButtonFormField<String>,
'Team Leader',
);
await tester.tap(leaderDropdown);
await tester.pumpAndSettle();
await tester.tap(find.text('Jamie Tech').last);
await tester.pumpAndSettle();
// Try to add without selecting offices -> should show validation SnackBar
await tester.tap(find.text('Add'));
await tester.pumpAndSettle();
expect(
find.text('Assign at least one office to the team'),
findsOneWidget,
);
});
testWidgets('Add Team dialog: opening Offices dropdown does not overflow', (
tester,
) async {
await _setSurfaceSize(tester, const Size(600, 800));
await _pumpScreen(
tester,
const TeamsScreen(),
overrides: [
...baseOverrides(),
teamsProvider.overrideWith((ref) => Stream.value(const <Team>[])),
teamMembersProvider.overrideWith(
(ref) => Stream.value(const <TeamMember>[]),
),
],
);
// Open Add Team dialog
await tester.tap(find.byType(FloatingActionButton));
await tester.pumpAndSettle();
// Find Offices InputDecorator and tap its Select ActionChip
final officesField = find.widgetWithText(InputDecorator, 'Offices');
expect(officesField, findsOneWidget);
final selectChip = find.descendant(
of: officesField,
matching: find.widgetWithText(ActionChip, 'Select'),
);
expect(selectChip, findsOneWidget);
await tester.tap(selectChip);
await tester.pumpAndSettle();
// Inner dialog should appear and no layout overflow exceptions should be thrown
expect(find.text('Select Offices'), findsOneWidget);
expect(tester.takeException(), isNull);
// The list should contain the sample office
expect(find.widgetWithText(CheckboxListTile, 'HQ'), findsOneWidget);
});
testWidgets('User management renders without layout exceptions', (
tester,
) async {
@@ -0,0 +1,105 @@
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:tasq/models/office.dart';
import 'package:tasq/widgets/multi_select_picker.dart';
void main() {
testWidgets(
'SearchableMultiSelectDropdown: search / select-all / chips update',
(WidgetTester tester) async {
final offices = [
Office(id: 'o1', name: 'HQ'),
Office(id: 'o2', name: 'Branch'),
Office(id: 'o3', name: 'Remote'),
];
// Host state for selected IDs
List<String> selected = ['o1'];
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: StatefulBuilder(
builder: (context, setState) {
return Padding(
padding: const EdgeInsets.all(16.0),
child: MultiSelectPicker<Office>(
label: 'Offices',
items: offices,
selectedIds: selected,
getId: (o) => o.id,
getLabel: (o) => o.name,
onChanged: (ids) => setState(() => selected = ids),
),
);
},
),
),
),
);
// Initially the selected chip for 'HQ' must be visible
expect(find.text('HQ'), findsOneWidget);
expect(selected, equals(['o1']));
// Open dropdown dialog
await tester.tap(find.text('Select'));
await tester.pumpAndSettle();
// Dialog title present
expect(find.text('Select Offices'), findsOneWidget);
// All items are visible in the list initially
expect(find.widgetWithText(CheckboxListTile, 'HQ'), findsOneWidget);
expect(find.widgetWithText(CheckboxListTile, 'Branch'), findsOneWidget);
expect(find.widgetWithText(CheckboxListTile, 'Remote'), findsOneWidget);
// Search for 'Branch' -> only Branch should remain in the list
final searchField = find.descendant(
of: find.byType(AlertDialog),
matching: find.byType(TextField),
);
expect(searchField, findsOneWidget);
await tester.enterText(searchField, 'Branch');
await tester.pumpAndSettle();
expect(find.widgetWithText(CheckboxListTile, 'Branch'), findsOneWidget);
expect(find.widgetWithText(CheckboxListTile, 'HQ'), findsNothing);
expect(find.widgetWithText(CheckboxListTile, 'Remote'), findsNothing);
// Clear search, then use Select All
await tester.enterText(searchField, '');
await tester.pumpAndSettle();
await tester.tap(find.widgetWithText(CheckboxListTile, 'Select All'));
await tester.pumpAndSettle();
// Press Done to apply selection
await tester.tap(find.text('Done'));
await tester.pumpAndSettle();
// Now all chips should be present and selected list updated
expect(find.text('HQ'), findsOneWidget);
expect(find.text('Branch'), findsOneWidget);
expect(find.text('Remote'), findsOneWidget);
expect(selected.toSet(), equals({'o1', 'o2', 'o3'}));
// Re-open dialog and uncheck 'HQ'
await tester.tap(find.text('Select'));
await tester.pumpAndSettle();
await tester.tap(find.widgetWithText(CheckboxListTile, 'HQ'));
await tester.pumpAndSettle();
await tester.tap(find.text('Done'));
await tester.pumpAndSettle();
// HQ chip should be removed, others remain
expect(find.text('HQ'), findsNothing);
expect(find.text('Branch'), findsOneWidget);
expect(find.text('Remote'), findsOneWidget);
expect(selected.toSet(), equals({'o2', 'o3'}));
},
);
}
@@ -0,0 +1,38 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:tasq/services/admin_profile_service.dart';
class _FakeFromBuilder {
Map<String, dynamic>? lastUpdate;
String? lastEqCol;
String? lastEqVal;
_FakeFromBuilder update(Map<String, dynamic> v) {
lastUpdate = v;
return this;
}
_FakeFromBuilder eq(String col, String val) {
lastEqCol = col;
lastEqVal = val;
return this;
}
_FakeFromBuilder select() => this;
Future<dynamic> maybeSingle() async => {'error': null, 'data': lastUpdate};
}
class _FakeSupabaseClient {
final _FakeFromBuilder builder = _FakeFromBuilder();
dynamic from(String _) => builder;
}
void main() {
test('setUserLock updates is_locked on profiles', () async {
final fake = _FakeSupabaseClient();
final svc = AdminProfileService(fake as dynamic);
await svc.setUserLock('user-123', true);
expect(fake.builder.lastUpdate, {'is_locked': true});
expect(fake.builder.lastEqCol, 'id');
expect(fake.builder.lastEqVal, 'user-123');
});
}
+139
View File
@@ -0,0 +1,139 @@
import 'package:flutter/material.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:supabase_flutter/supabase_flutter.dart';
import 'package:tasq/models/office.dart';
import 'package:tasq/models/profile.dart';
import 'package:tasq/models/team.dart';
import 'package:tasq/models/team_member.dart';
import 'package:tasq/providers/teams_provider.dart';
import 'package:tasq/providers/profile_provider.dart';
import 'package:tasq/providers/tickets_provider.dart';
import 'package:tasq/screens/teams/teams_screen.dart';
import 'package:tasq/providers/supabase_provider.dart';
import 'package:tasq/widgets/multi_select_picker.dart';
SupabaseClient _fakeSupabaseClient() =>
SupabaseClient('http://localhost', 'test-key');
void main() {
final office = Office(id: 'office-1', name: 'HQ');
final admin = Profile(id: 'user-1', role: 'admin', fullName: 'Alex Admin');
final tech = Profile(id: 'user-2', role: 'it_staff', fullName: 'Jamie Tech');
List<Override> baseOverrides() {
return [
supabaseClientProvider.overrideWithValue(_fakeSupabaseClient()),
currentProfileProvider.overrideWith((ref) => Stream.value(admin)),
profilesProvider.overrideWith((ref) => Stream.value([admin, tech])),
officesProvider.overrideWith((ref) => Stream.value([office])),
teamsProvider.overrideWith((ref) => Stream.value(const <Team>[])),
teamMembersProvider.overrideWith(
(ref) => Stream.value(const <TeamMember>[]),
),
];
}
testWidgets('Add Team dialog: leader dropdown shows only it_staff', (
WidgetTester tester,
) async {
await tester.binding.setSurfaceSize(const Size(600, 800));
addTearDown(() async => await tester.binding.setSurfaceSize(null));
await tester.pumpWidget(
ProviderScope(
overrides: baseOverrides(),
child: const MaterialApp(home: Scaffold(body: TeamsScreen())),
),
);
// Open Add Team dialog
await tester.tap(find.byType(FloatingActionButton));
await tester.pumpAndSettle();
// Open the dropdown overlay and assert only the it_staff option is shown.
final leaderDropdown = find.widgetWithText(
DropdownButtonFormField<String>,
'Team Leader',
);
expect(leaderDropdown, findsOneWidget);
await tester.tap(leaderDropdown);
await tester.pumpAndSettle();
// The dropdown overlay should show the it_staff option and not the admin.
expect(find.text('Jamie Tech'), findsOneWidget);
expect(find.text('Alex Admin'), findsNothing);
});
testWidgets('Add Team dialog: Team Members picker shows only it_staff', (
WidgetTester tester,
) async {
await tester.binding.setSurfaceSize(const Size(600, 800));
addTearDown(() async => await tester.binding.setSurfaceSize(null));
await tester.pumpWidget(
ProviderScope(
overrides: baseOverrides(),
child: const MaterialApp(home: Scaffold(body: TeamsScreen())),
),
);
// Open Add Team dialog
await tester.tap(find.byType(FloatingActionButton));
await tester.pumpAndSettle();
// Inspect the MultiSelectPicker widget for 'Team Members' directly
final pickerFinder = find.byWidgetPredicate(
(w) => w is MultiSelectPicker<Profile> && w.label == 'Team Members',
);
expect(pickerFinder, findsOneWidget);
final picker = tester.widget<MultiSelectPicker<Profile>>(pickerFinder);
final labels = picker.items.map(picker.getLabel).toList();
expect(labels, contains('Jamie Tech'));
expect(labels, isNot(contains('Alex Admin')));
});
testWidgets(
'Add Team dialog uses fixed width on desktop and bottom-sheet on mobile',
(WidgetTester tester) async {
// Desktop -> AlertDialog constrained to max width
await tester.binding.setSurfaceSize(const Size(1024, 800));
addTearDown(() async => await tester.binding.setSurfaceSize(null));
await tester.pumpWidget(
ProviderScope(
overrides: baseOverrides(),
child: const MaterialApp(home: Scaffold(body: TeamsScreen())),
),
);
await tester.tap(find.byType(FloatingActionButton));
await tester.pumpAndSettle();
expect(find.byType(AlertDialog), findsOneWidget);
final dialogSize = tester.getSize(find.byType(AlertDialog));
expect(dialogSize.width, lessThanOrEqualTo(720));
// Close desktop dialog
await tester.tap(find.text('Cancel'));
await tester.pumpAndSettle();
// Mobile -> bottom sheet presentation
await tester.binding.setSurfaceSize(const Size(600, 800));
await tester.pumpWidget(
ProviderScope(
overrides: baseOverrides(),
child: const MaterialApp(home: Scaffold(body: TeamsScreen())),
),
);
await tester.tap(find.byType(FloatingActionButton));
await tester.pumpAndSettle();
expect(find.byType(BottomSheet), findsWidgets);
expect(find.text('Team Name'), findsOneWidget);
},
);
}